As Norm said - scans are generally clearer.
However some cards are best photographed to capture their design - so it depends on the card, but generally scan would be the one to go with.
Yeah anything refractor-like or holographic or anything is probably best to photograph. Here's a comparison I happen to be able to provide:
Camera -
Scan -
I find it hard to scan graded cards, they don't come up as clear so I use photos
\
On the same topic, what's a good/acceptible DPI to scan with these days?
I think I used to scan at around 600DPI, but they were too large, and when they were reduced to thumbnails, they looked crap. I think I'm scanning around 300DPI these days, but they still look crap:
Maybe I need a new scanner. Currently (or still) using my HP2610 All-In-1, which has a scanner bed on top of the printer.
^Thanks Alf.
Question, does that look alright above?